linux-kernel - Re: [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <75f9f165-cfa8-d43d-e7c0-17ccee673de5@web.de>
Date:   Wed, 29 Apr 2020 14:41:12 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        Richard Gong <richard.gong@...ux.intel.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alan Tull <atull@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Moritz Fischer <mdf@...nel.org>
Subject: Re: [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code

> Replace 'devm_kmalloc_array(... | __GFP_ZERO)' with the equivalent and
> shorter 'devm_kcalloc(...)'.
>
> 'ctrl->genpool' can not be NULL, so axe a useless test in the remove
> function.

I would find it clearer to integrate also such small source code improvements
by separate patches.

Regards,
Markus