linux-kernel - Re: [PATCH] staging: wfx: avoid compiler warning on empty array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3063047.NHY2raB2sq@pc-42>
Date:   Thu, 30 Apr 2020 08:42:24 +0000
From:   Jerome Pouiller <Jerome.Pouiller@...abs.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jules Irenge <jbi.octave@...il.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: wfx: avoid compiler warning on empty array

On Wednesday 29 April 2020 22:34:56 CEST Arnd Bergmann wrote:
> 
> On Wed, Apr 29, 2020 at 6:04 PM Jerome Pouiller
> <Jerome.Pouiller@...abs.com> wrote:
> > On Wednesday 29 April 2020 16:21:09 CEST Arnd Bergmann wrote:
> > >
> > > -static const struct of_device_id wfx_sdio_of_match[];
> > > +static const struct of_device_id wfx_sdio_of_match[] = {
> > > +       { .compatible = "silabs,wfx-sdio" },
> > > +       { .compatible = "silabs,wf200" },
> > > +       { },
> > > +};
> > > +MODULE_DEVICE_TABLE(of, wfx_sdio_of_match);
> >
> > I suggest to keep the '#ifdef CONFIG_OF' around this definition. If
> > CONFIG_OF is undefined, of_match_ptr() and of_match_node() will be NULL
> > and it should compile.
> 
> I would generally always go for fewer #ifdef instead of more when the result
> is the same. Are you worried about wasting 600 bytes of object code size for
> the array on systems that need this driver but not CONFIG_OF, or something
> else?

I am not very concerned about the size of the object. However, I think
that all the modules should apply the same policy regarding the device
tables. With a few greps, I found 3954 struct of_device_id. About 500 are
inside #ifdef and about 1000 use of_match_ptr().

Should we consider that the structs of_device_id have to be defined even
if CONFIG_OF is not defined? And In this case, should we drop
of_match_ptr()?

Or in contrary, when kernel is compiled without CONFIG_OF, no modules
should contains OF entries in its device table?

-- 
Jérôme Pouiller