lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 May 2020 05:34:29 -0700
From:   Christoph Hellwig <>
To:     Joonsoo Kim <>
Cc:     Christoph Hellwig <>,
        Andrew Morton <>,
        Linux Memory Management List <>,
        LKML <>,
        Vlastimil Babka <>,
        Laura Abbott <>,
        "Aneesh Kumar K . V" <>,
        Mel Gorman <>,
        Michal Hocko <>,
        Johannes Weiner <>,
        Roman Gushchin <>, Minchan Kim <>,
        Rik van Riel <>,
        Christian Koenig <>,
        Huang Rui <>,
        Eric Biederman <>,
        "Rafael J . Wysocki" <>,
        Pavel Machek <>,,
        Joonsoo Kim <>
Subject: Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote:
> I think that PageHighMemZone() is long and complicated enough to have
> a macro.

It is.  But then again it also shouldn't really be used by anything
but MM internals.

> PageHighMemZone(page) = is_highmem_idx(zone_idx(page_zone(page))
> Instead of open-code, how about changing the style of macro like as
> page_from_highmem()? What PageHighMemZone() represent is derivated
> attribute from the page so PageXXX() style may not be appropriate.

Maybe page_is_highmem_zone() with a big kerneldoc comment explaining
the use case?  Bonus points of killing enough users that it can be
in mm/internal.h.

Powered by blists - more mailing lists