linux-kernel - Re: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5533a7b4-12b4-90b8-2731-a9cdfbee5e12@gmail.com>
Date:   Sat, 2 May 2020 23:51:21 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Dan Murphy <dmurphy@...com>, pavel@....cz
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class
 definition

Dan,

I've converted drivers/leds/leds-an30259a.c to LED mc framework
and tested it on Samsung Galaxy S3 (exysnos4412-trats2 board).
Works as expected. And now the framework usability is indeed neater.

One thing to improve: LED mc based drivers' entries in Kconfig should 
have this dependency:

depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR

It is required to enforce building driver as a module if
LED mc framework is configured as such.

With this (and DT bindings nits) addressed, for patches 1-6:

Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>

It's been a long journey. Thank you for your determination to drive
this work to the end.

Best regards,
Jacek Anaszewski

On 4/29/20 10:28 PM, Dan Murphy wrote:
> Introduce a multicolor class that groups colored LEDs
> within a LED node.
> 
> The multi color class groups monochrome LEDs and allows controlling two
> aspects of the final combined color: hue and lightness. The former is
> controlled via the intensity file and the latter is controlled
> via brightness file.
> 
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
>   .../ABI/testing/sysfs-class-led-multicolor    |  34 +++
>   Documentation/leds/index.rst                  |   1 +
>   Documentation/leds/leds-class-multicolor.rst  |  86 +++++++
>   MAINTAINERS                                   |   8 +
>   drivers/leds/Kconfig                          |  10 +
>   drivers/leds/Makefile                         |   1 +
>   drivers/leds/led-class-multicolor.c           | 210 ++++++++++++++++++
>   include/linux/led-class-multicolor.h          | 121 ++++++++++
>   8 files changed, 471 insertions(+)
>   create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
>   create mode 100644 Documentation/leds/leds-class-multicolor.rst
>   create mode 100644 drivers/leds/led-class-multicolor.c
>   create mode 100644 include/linux/led-class-multicolor.h
[...]