linux-kernel - Re: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05377684-c316-24c2-d577-f52b8eea5656@ti.com>
Date:   Sun, 3 May 2020 07:26:28 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>, <pavel@....cz>
CC:     <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class
 definition

Jacek

On 5/2/20 4:51 PM, Jacek Anaszewski wrote:
> Dan,
>
> I've converted drivers/leds/leds-an30259a.c to LED mc framework
> and tested it on Samsung Galaxy S3 (exysnos4412-trats2 board).
> Works as expected. And now the framework usability is indeed neater.
>
> One thing to improve: LED mc based drivers' entries in Kconfig should 
> have this dependency:
>
> depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
>
> It is required to enforce building driver as a module if
> LED mc framework is configured as such.
>
Do you think the FLASH class needs this as well?  If so I will send this 
in a separate patch


> With this (and DT bindings nits) addressed, for patches 1-6:
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
>
Ack
> It's been a long journey. Thank you for your determination to drive
> this work to the end.
>
Ack to that.

Dan