[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAmzW4Mcar3PfL+_VV66hxJ1H2rMJxskiJ7JYvcbWp4yRYyXvg@mail.gmail.com>
Date: Mon, 4 May 2020 12:09:11 +0900
From: Joonsoo Kim <js1304@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>,
Vlastimil Babka <vbabka@...e.cz>,
Laura Abbott <labbott@...hat.com>,
"Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
Mel Gorman <mgorman@...hsingularity.net>,
Michal Hocko <mhocko@...e.com>,
Johannes Weiner <hannes@...xchg.org>,
Roman Gushchin <guro@...com>, Minchan Kim <minchan@...nel.org>,
Rik van Riel <riel@...riel.com>,
Christian Koenig <christian.koenig@....com>,
Huang Rui <ray.huang@....com>,
Eric Biederman <ebiederm@...ssion.com>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Pavel Machek <pavel@....cz>, kernel-team@....com,
Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v2 00/10] change the implementation of the PageHighMem()
2020년 5월 1일 (금) 오후 9:34, Christoph Hellwig <hch@...radead.org>님이 작성:
>
> On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote:
> > I think that PageHighMemZone() is long and complicated enough to have
> > a macro.
>
> It is. But then again it also shouldn't really be used by anything
> but MM internals.
I'm not sure that we can make it MM internal but I will try.
> >
> > PageHighMemZone(page) = is_highmem_idx(zone_idx(page_zone(page))
> >
> > Instead of open-code, how about changing the style of macro like as
> > page_from_highmem()? What PageHighMemZone() represent is derivated
> > attribute from the page so PageXXX() style may not be appropriate.
>
> Maybe page_is_highmem_zone() with a big kerneldoc comment explaining
> the use case? Bonus points of killing enough users that it can be
> in mm/internal.h.
I will try to kill page_is_highmem_zone() as much as possible in next version.
Thanks.
Powered by blists - more mailing lists