linux-kernel - Re: [PATCH] selftests/vm/keys: fix a broken reference at protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43841ceb-f682-26ff-8b57-fed545759193@linux.ibm.com>
Date:   Mon, 4 May 2020 20:08:42 +0530
From:   Sandipan Das <sandipan@...ux.ibm.com>
To:     Dave Hansen <dave.hansen@...el.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        Jonathan Corbet <corbet@....net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Ram Pai <linuxram@...ibm.com>,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/vm/keys: fix a broken reference at
 protection_keys.c



On 04/05/20 7:40 pm, Dave Hansen wrote:
> On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
>> Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
>> from Jun 7, 2019 converted protection-keys.txt file to ReST.
>>
>> A recent change at protection_keys.c partially reverted such
>> changeset, causing it to point to a non-existing file:
>>
>> 	- * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
>> 	+ * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
>>
>> It sounds to me that the changeset that introduced such change
>> 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
>> could also have other side effects, as it sounds that it was not
>> generated against uptream code, but, instead, against a version
>> older than Jun 7, 2019.
>>
>> Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> 
> Thanks for finding this!  The patch set which moved protection-keys.txt
> out of x86 code probably just missed this when it got rebased.  It
> originated well before June 2019, iirc.
> 

That's right. Sorry about that. Must have missed it when rebasing the
older pkey selftest patches. Thanks for fixing this Mauro.

Acked-by: Sandipan Das <sandipan@...ux.ibm.com>