linux-kernel - Re: [PATCH] selftests/vm/keys: fix a broken reference at protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ad59d36-ee2d-a37c-cbaa-42c3071a03c0@kernel.org>
Date:   Fri, 8 May 2020 09:54:50 -0600
From:   shuah <shuah@...nel.org>
To:     Sandipan Das <sandipan@...ux.ibm.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Ram Pai <linuxram@...ibm.com>,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
        linux-kselftest@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH] selftests/vm/keys: fix a broken reference at
 protection_keys.c

On 5/4/20 8:38 AM, Sandipan Das wrote:
> 
> 
> On 04/05/20 7:40 pm, Dave Hansen wrote:
>> On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
>>> Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")

checkpatch doesn't like this commit description.

ERROR: Please use git commit description style 'commit <12+ chars of 
sha1> ("<title line>")' - ie: 'commit 1eecbcdca2bd ("docs: move 
protection-keys.rst to the core-api book")'
#72:
Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api 
book")

>>> from Jun 7, 2019 converted protection-keys.txt file to ReST.
>>>
>>> A recent change at protection_keys.c partially reverted such
>>> changeset, causing it to point to a non-existing file:
>>>
>>> 	- * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
>>> 	+ * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
>>>
>>> It sounds to me that the changeset that introduced such change
>>> 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
>>> could also have other side effects, as it sounds that it was not
>>> generated against uptream code, but, instead, against a version
>>> older than Jun 7, 2019.
>>>
>>> Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")

WARNING: Unknown commit id '4645e3563673', maybe rebased or not pulled?
#87:
Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru 
to a generic name")

This commit didn't land in Linux 5.7-rc4 yet looks like. Probably in mm
or doc tree and has dependency on it?

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah