linux-kernel - Re: [PATCH] fs: jfs: fix a possible data race in txBegin()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ef374a5-0e2e-5c74-a827-0148c384f6e3@web.de>
Date:   Mon, 4 May 2020 18:15:48 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Jia-Ju Bai <baijiaju1990@...il.com>,
        jfs-discussion@...ts.sourceforge.net
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Dave Kleikamp <shaggy@...nel.org>
Subject: Re: [PATCH] fs: jfs: fix a possible data race in txBegin()

> Thus, a data race can occur for tblk->flag.
>
> To fix this data race, the spinlock log->gclock is used in
> txBegin().
>
> This data race is found by our concurrency fuzzer.

How do you think about a wording variant like the following?

   Change description:
   A data race can occur for the data structure member “flag”.
   This data race was found by our concurrency fuzzer.

   Thus use the spin lock “gclock” for the resetting of five
   data structure members in this function implementation.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus