linux-kernel - Re: [PATCH] fs: jfs: fix a possible data race in metapage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bcfeb785-b787-4ebe-c1e1-159b6efc7e51@web.de>
Date:   Mon, 4 May 2020 18:33:40 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Jia-Ju Bai <baijiaju1990@...il.com>,
        jfs-discussion@...ts.sourceforge.net
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Dave Kleikamp <shaggy@...nel.org>
Subject: Re: [PATCH] fs: jfs: fix a possible data race in metapage_writepage()

…
> To fix this data race, the spinlock mp->log->gclock is used in
> metapage_writepage().
>
> This data race is found by our concurrency fuzzer.

How do you think about a wording variant like the following?

   Change description:
   …
   This data race was found by our concurrency fuzzer.

   Thus use the spin lock “mp->log->gclock” for the assignment of
   the data structure member “log->cflag” to a local variable
   in this function implementation.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus