linux-kernel - Re: [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <811b4acf-1356-1b82-edf3-29e73d2ed9d3@redhat.com>
Date:   Mon, 4 May 2020 18:35:53 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Cathy Avery <cavery@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test
 correctly

On 28/04/20 20:41, Cathy Avery wrote:
> The last test does not return vmmcall on fail resulting
> in passing the entire test.
> 
> Signed-off-by: Cathy Avery <cavery@...hat.com>
> ---
>  x86/svm_tests.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/x86/svm_tests.c b/x86/svm_tests.c
> index 2b84e4d..65008ba 100644
> --- a/x86/svm_tests.c
> +++ b/x86/svm_tests.c
> @@ -1480,6 +1480,7 @@ static void nmi_hlt_test(struct svm_test *test)
>      if (!nmi_fired) {
>          report(nmi_fired, "intercepted pending NMI not dispatched");
>          set_test_stage(test, -1);
> +        vmmcall();
>      }
>  
>      set_test_stage(test, 3);
> 

Queued, thanks.

Paolo