linux-kernel - Re: [PATCH] samples: fix binderfs sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200505094835.47cc2d53@lwn.net>
Date:   Tue, 5 May 2020 09:48:35 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Christian Brauner <christian@...uner.io>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples: fix binderfs sample

On Wed, 29 Apr 2020 10:01:13 +0200
Christian Brauner <christian.brauner@...ntu.com> wrote:

> On Tue, Apr 28, 2020 at 11:25:33PM +0200, Arnd Bergmann wrote:
> > A routine check for misspelled Kconfig symbols showed on instance
> > from last year, the correct symbol name is CONFIG_ANDROID_BINDERFS,
> > not CONFIG_CONFIG_ANDROID_BINDERFS, so the extra prefix must
> > be removed in the Kconfig file to allow enabling the sample.
> > 
> > As the actual sample fails to build as a kernel module, change the
> > Makefile enough to get to build as a hostprog instead.
> > 
> > Fixes: 9762dc1432e1 ("samples: add binderfs sample program")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>  
> 
> Thanks for fixing this Arnd!
> Acked-by: Christian Brauner <christian.brauner@...ntu.com>
> 
I've applied this, thanks.

jon