lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 05 May 2020 14:24:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bhsharma@...hat.com
Cc:     netdev@...r.kernel.org, bhupesh.linux@...il.com,
        kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
        aelior@...vell.com, GR-everest-linux-l2@...vell.com,
        manishc@...vell.com
Subject: Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count
 when running inside kdump kernel

From: Bhupesh Sharma <bhsharma@...hat.com>
Date: Wed,  6 May 2020 00:34:40 +0530

> -#define NUM_RX_BDS_DEF		((u16)BIT(10) - 1)
> +#define NUM_RX_BDS_DEF		((is_kdump_kernel()) ? ((u16)BIT(6) - 1) : ((u16)BIT(10) - 1))

These parenthesis are very excessive and unnecessary.  At the
very least remove the parenthesis around is_kdump_kernel().

Powered by blists - more mailing lists