[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 5 May 2020 15:20:46 +0100
From: Russell King - ARM Linux admin <linux@...linux.org.uk>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Calvin Johnson <calvin.johnson@....nxp.com>,
"Rafael J . Wysocki" <rafael@...nel.org>, linux.cj@...il.com,
Jeremy Linton <jeremy.linton@....com>,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Cristi Sovaiala <cristian.sovaiala@....com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
Ioana Ciornei <ioana.ciornei@....com>,
Madalin Bucur <madalin.bucur@....nxp.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Varun Sethi <V.Sethi@....com>,
"Rajesh V . Bikkina" <rajesh.bikkina@....com>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Diana Madalina Craciun <diana.craciun@....com>,
netdev <netdev@...r.kernel.org>, Marcin Wojtas <mw@...ihalf.com>,
Laurentiu Tudor <laurentiu.tudor@....com>,
Makarand Pawagi <makarand.pawagi@....com>,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
Pankaj Bansal <pankaj.bansal@....com>,
"David S. Miller" <davem@...emloft.net>,
Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()
On Tue, May 05, 2020 at 05:15:16PM +0300, Andy Shevchenko wrote:
> On Tue, May 5, 2020 at 4:29 PM Calvin Johnson
> > + if (sscanf(cp, "ethernet-phy-id%4x.%4x",
> > + &upper, &lower) == 2) {
>
> > + *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF);
>
> How upper can be bigger than 0xfff? Same for lower.
I think your comment is incorrect here. Four hex digits can be larger
than 0xfff. "1000" interpreted as hex is four hex digits and larger
than 0xfff, for example.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Powered by blists - more mailing lists