linux-kernel - Re: [PATCH -next] cpupower: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d1333ae-6d7f-a456-567b-34852270000b@huawei.com>
Date:   Wed, 6 May 2020 08:52:15 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     shuah <shuah@...nel.org>, <trenn@...e.com>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] cpupower: Remove unneeded semicolon

Hi Shuah,

I run with the below command, and get the output report.

[local-host linux-next]# make coccicheck MODE=report 
M=tools/power/cpupower/utils

Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:175:2-3: 
Unneeded semicolon
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:56:2-3: Unneeded 
semicolon
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:75:2-3: Unneeded 
semicolon
tools/power/cpupower/utils/idle_monitor/snb_idle.c:80:2-3: Unneeded 
semicolon
tools/power/cpupower/utils/cpupower-set.c:75:2-3: Unneeded semicolon
tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c:82:2-3: Unneeded 
semicolon
tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c:120:2-3: 
Unneeded semicolon
tools/power/cpupower/utils/idle_monitor/nhm_idle.c:94:2-3: Unneeded 
semicolon
tools/power/cpupower/utils/cpupower-info.c:65:2-3: Unneeded semicolon

On 2020/5/2 1:07, shuah wrote:
> Hi Zou Wei,
> 
> On 4/28/20 3:43 AM, Zou Wei wrote:
>> Fixes coccicheck warnings:
> 
> I am not finding these in my coccicheck run. Can you send me the options
> you are using?
> 
>>
>> tools/power/cpupower/utils/cpupower-info.c:65:2-3: Unneeded semicolon
>> tools/power/cpupower/utils/cpupower-set.c:75:2-3: Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c:120:2-3: 
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:175:2-3: 
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:56:2-3: 
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:75:2-3: 
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c:82:2-3: 
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/nhm_idle.c:94:2-3: Unneeded 
>> semicolon
>> tools/power/cpupower/utils/idle_monitor/snb_idle.c:80:2-3: Unneeded 
>> semicolon
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zou Wei <zou_wei@...wei.com>
>> ---
>>   tools/power/cpupower/utils/cpupower-info.c                | 2 +-
>>   tools/power/cpupower/utils/cpupower-set.c                 | 2 +-
>>   tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c | 2 +-
>>   tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c   | 6 +++---
>>   tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c    | 2 +-
>>   tools/power/cpupower/utils/idle_monitor/nhm_idle.c        | 2 +-
>>   tools/power/cpupower/utils/idle_monitor/snb_idle.c        | 2 +-
>>   7 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/power/cpupower/utils/cpupower-info.c 
>> b/tools/power/cpupower/utils/cpupower-info.c
>> index d3755ea..0ba61a2 100644
>> --- a/tools/power/cpupower/utils/cpupower-info.c
>> +++ b/tools/power/cpupower/utils/cpupower-info.c
>> @@ -62,7 +62,7 @@ int cmd_info(int argc, char **argv)
>>           default:
>>               print_wrong_arg_exit();
>>           }
>> -    };
>> +    }
> 
> The patch itself is fine.
> 
> thanks,
> -- Shuah
> 
> .