linux-kernel - Re: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.2005080948560.19653-100000@netrider.rowland.org>
Date:   Fri, 8 May 2020 09:49:19 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Tang Bin <tangbin@...s.chinamobile.com>
cc:     gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()

On Fri, 8 May 2020, Tang Bin wrote:

> Delete unused initialized value, because 'retval' will be assigined
> by the function mv_ehci_enable().

This should also mention the extra blank line that the patch removes.

Alan Stern

> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
>  drivers/usb/host/ehci-mv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index bd4f6ef53..1c079953e 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
>  	struct ehci_hcd *ehci;
>  	struct ehci_hcd_mv *ehci_mv;
>  	struct resource *r;
> -	int retval = -ENODEV;
> +	int retval;
>  	u32 offset;
>  
>  	if (usb_disabled())
> @@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
>  		goto err_put_hcd;
>  	}
>  
> -
> -
>  	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
>  	if (IS_ERR(ehci_mv->base)) {
>