linux-kernel - Re: [PATCH -next] dm mpath: Remove unused variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d945a16d-5a9d-252f-2dec-1d654c4f7e77@huawei.com>
Date:   Fri, 8 May 2020 09:06:08 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     Mike Snitzer <snitzer@...hat.com>
CC:     <agk@...hat.com>, <dm-devel@...hat.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] dm mpath: Remove unused variable ret

Hi Mike,

You are right.
I did not notice that the macro DMEMIT uses the sz variable.

Thanks.

On 2020/5/7 22:29, Mike Snitzer wrote:
> On Thu, May 07 2020 at  8:26am -0400,
> Samuel Zou <zou_wei@...wei.com> wrote:
> 
>> This patch fixes below warning reported by coccicheck:
>>
>> drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz". Return "0" on line 261
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Samuel Zou <zou_wei@...wei.com>
> 
> Nack.
> 
> DMEMIT() uses the local sz variable.
> 
>