linux-kernel - Re: [PATCH][next] net: phy: fix less than zero comparison with unsigned variable val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200507.180758.1608657964463079833.davem@davemloft.net>
Date:   Thu, 07 May 2020 18:07:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux@...linux.org.uk, linux@...pel-privat.de,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: phy: fix less than zero comparison with
 unsigned variable val

From: Colin King <colin.king@...onical.com>
Date: Thu,  7 May 2020 15:34:30 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The unsigned variable val is being checked for an error by checking
> if it is less than zero. This can never occur because val is unsigned.
> Fix this by making val a plain int.
> 
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: bdbdac7649fa ("ethtool: provide UAPI for PHY master/slave configuration.")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks Colin.