linux-kernel - Re:Re: [PATCH] drm/exynos: remove no need devm_kfree in probe [re-send, welcome any comments]

Open Source and information security mailing list archives

Message-ID: <AEMAEgD6CFDEXGkP4OWX94rO.3.1588927460255.Hmail.bernard@vivo.com>
Date:   Fri, 8 May 2020 16:44:20 +0800 (GMT+08:00)
From:   Bernard <bernard@...o.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Inki Dae <inki.dae@...sung.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re:Re: [PATCH] drm/exynos: remove no need devm_kfree in probe [re-send, welcome any comments]

From: Sam Ravnborg <sam@...nborg.org>
Date: 2020-05-08 15:52:10
To:  Bernard <bernard@...o.com>
Cc:  Inki Dae <inki.dae@...sung.com>,Joonyoung Shim <jy0922.shim@...sung.com>,Seung-Woo Kim <sw0312.kim@...sung.com>,Kyungmin Park <kyungmin.park@...sung.com>,David Airlie <airlied@...ux.ie>,Daniel Vetter <daniel@...ll.ch>,Kukjin Kim <kgene@...nel.org>,Krzysztof Kozlowski <krzk@...nel.org>,dri-devel@...ts.freedesktop.org,linux-arm-kernel@...ts.infradead.org,linux-samsung-soc@...r.kernel.org,linux-kernel@...r.kernel.org,opensource.kernel@...o.com
Subject: Re: [PATCH] drm/exynos: remove no need devm_kfree in probe [re-send, welcome any comments]>Hi Bernard.
>
>On Wed, May 06, 2020 at 08:49:03PM +0800, Bernard wrote:
>> Remove no need devm_kfree in probe.
>> The change is to make the code a bit more readable
>> 
>> Signed-off-by: Bernard Zhao <bernard@...o.com>
>
>Could you take a closer look and fix similar patterns
>in the rest of the driver?
>For example in exynos_dpi_probe()
>
>Is would be nice to only have to review for this
>type of changes once, so one patch-set is preferred
>over single patches over time.
>
>You can add:
>Reviewed-by: Sam Ravnborg <sam@...nborg.org>
>
>to this patch when you re-send a new series.
>
>Thanks,
>	Sam

Hi
Sure, this is also a good chance for me to learn this code.
I will re-check this part of the exynos driver code to see 
if there are similar patterns, and then re-send a patch series.

Regards,
Bernard

>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_dpi.c | 10 +++-------
>>  1 file changed, 3 insertions(+), 7 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
>> index 43fa0f26c052..e06f7d7a6695 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
>> @@ -181,10 +181,8 @@ static int exynos_dpi_parse_dt(struct exynos_dpi *ctx)
>>  			return -ENOMEM;
>>  
>>  		ret = of_get_videomode(dn, vm, 0);
>> -		if (ret < 0) {
>> -			devm_kfree(dev, vm);
>> +		if (ret < 0)
>>  			return ret;
>> -		}
>>  
>>  		ctx->vm = vm;
>>  
>> @@ -233,10 +231,8 @@ struct drm_encoder *exynos_dpi_probe(struct device *dev)
>>  	ctx->dev = dev;
>>  
>>  	ret = exynos_dpi_parse_dt(ctx);
>> -	if (ret < 0) {
>> -		devm_kfree(dev, ctx);
>> -		return NULL;
>> -	}
>> +	if (ret < 0)
>> +		return ERR_PTR(ret);
>>  
>>  	if (ctx->panel_node) {
>>  		ctx->panel = of_drm_find_panel(ctx->panel_node);
>> -- 
>> 2.26.2
>> 
>> 
>> [re-send, welcome any comments]
>> Regards,
>> Bernard
>> 
>> 
>> 
>> 
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives