linux-kernel - Re: [PATCH] sched/fair: Return true,false in voluntary_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 May 2020 11:24:30 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Peter Zijlstra <peterz@...radead.org>
cc:     Jason Yan <yanaijie@...wei.com>, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, linux-kernel@...r.kernel.org,
        linux@...musvillemoes.dk, Julia.Lawall@...6.fr
Subject: Re: [PATCH] sched/fair: Return true,false in
 voluntary_active_balance()

On Fri, 8 May 2020, Peter Zijlstra wrote:

> On Thu, May 07, 2020 at 07:06:25PM +0800, Jason Yan wrote:
> > Fix the following coccicheck warning:
> >
> > kernel/sched/fair.c:9375:9-10: WARNING: return of 0/1 in function
> > 'voluntary_active_balance' with return type bool
>
> That's not a warning, that's a broken cocinelle script, which if these
> stupid patches don't stop, I'm going to delete myself!

Peter,

If you don't like the script, please feel free to delete it.

Currently, no one is really maintaining (ie pushing patches to Linus) the
scripts directory.  Masahiro Yamada was doing it but has expressed several
times that he doesn't want to.  I got a kernel.org account, but clearly
haven't had time to figure out how to use it appropriately.  But simply
deleting a file is simple and risk free, so if you want to make the
change please go ahead.

julia