linux-kernel - Re: [v2] tools/bootconfig: fix resource leak in apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <131a5310-5d8e-5eb5-e55f-fa0a9a829ec1@web.de>
Date:   Fri, 8 May 2020 12:17:44 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yunfeng Ye <yeyunfeng@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Shiyuan Hu <hushiyuan@...wei.com>,
        Hewenliang <hewenliang4@...wei.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [v2] tools/bootconfig: fix resource leak in apply_xbc()

> Btw, these leaks are totally harmless.  This is a short running user
> space program with is going to immediately exit on error so the memory
> will be freed anyway.

Can such a view mean that the function call “free(data)” should be omitted here
for a quicker program termination?


> But the benifit is to silence static checker warnings so that's useful.

Would you like to extend the commit message for the explanation of
the importance of the proposed change accordingly?

Regards,
Markus