linux-kernel - Re: [PATCH 0/5] iio: accel: Add bma023 support to bma180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200508134733.0000233a@Huawei.com>
Date:   Fri, 8 May 2020 13:47:33 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Jonathan Bakker <xc-racer2@...e.ca>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Rob Herring <robh+dt@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Input <linux-input@...r.kernel.org>
Subject: Re: [PATCH 0/5] iio: accel: Add bma023 support to bma180

On Wed, 6 May 2020 20:49:17 -0700
Jonathan Bakker <xc-racer2@...e.ca> wrote:

> Hi Linus,
> 
> On 2020-05-06 5:47 a.m., Linus Walleij wrote:
> > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker <xc-racer2@...e.ca> wrote:
> >   
> >> This patchset adds support for the bma023 three axis accelerometer
> >> to the bma180 IIO driver.  The bma023 is found on several ~2010
> >> phones, including the first-gen Galaxy S series.
> >>
> >> The bma023 differs from later chips (bma180, bma25x) in that it
> >> has no low power but still working mode and no temperature
> >> channel.
> >>
> >> The bma023 is already supported by a misc input driver (bma150), so
> >> when both are enabled, the iio driver is preferred.  The bma150
> >> is very similar to the bma023, but has a temperature channel.
> >> Support for the bma150 is not added in this patchset.  
> > 
> > I'd say, if it's not too much trouble please also patch in
> > support for BMA150 and SMB380 to the IIO driver so
> > we can delete this old Input driver, we have done this
> > before and thes "input drivers" are just causing headaches
> > and wasting time for the Input maintainer.
> >   
> 
> Looking at the bma150, it looks the same.  The temperature is implemented
> slightly differently than on the bma180+ (unsigned vs signed) but should
> be quite easy to add.  I'll add a new patch for it in v2.

Great.  Series looks fine to me as well, so should be fine to apply v2.
(subject to Dmitry Ack).

Jonathan

> 
> > It can be in a separate patch set from this one if you
> > don't want to get stuck on this.
> > 
> > Yours,
> > Linus Walleij
> >   
> 
> Thanks,
> Jonathan