linux-kernel - Re: [PATCH v3] kernel: add panic_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200510051646.GF5029@MiWiFi-R3L-srv>
Date:   Sun, 10 May 2020 13:16:46 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Rafael Aquini <aquini@...hat.com>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, kexec@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org, dyoung@...hat.com, corbet@....net,
        mcgrof@...nel.org, keescook@...omium.org,
        akpm@...ux-foundation.org, cai@....pw, tytso@....edu,
        bunk@...nel.org, torvalds@...ux-foundation.org,
        gregkh@...uxfoundation.org, labbott@...hat.com, jeffm@...e.com,
        jikos@...nel.org, jeyu@...e.de, tiwai@...e.de, AnDavis@...e.com,
        rpalethorpe@...e.de
Subject: Re: [PATCH v3] kernel: add panic_on_taint

On 05/09/20 at 09:10pm, Randy Dunlap wrote:
> On 5/9/20 7:59 PM, Baoquan He wrote:
> > Read admin-guide/tainted-kernels.rst, but still do not get what 'G' means.
> 
> I interpret 'G' as GPL (strictly it means that no proprietary module has
> been loaded).  But I don't see why TAINT_PROPRIETARY_MODULE is the only
> taint flag that has a non-blank c_false character.  It could just be blank
> also AFAICT.  Then the 'G' would not be there to confuse us.  :)

Yeah, seems c_false character is not so necessary. If no 'P' set, then
it means no proprietary modules loaded naturally. We may need clean up
the c_false in struct taint_flag, since c_true is enough to indicate
what want to check.