linux-kernel - Re: [PATCH] docs/devicetree: mailbox: fix trivial typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 09:00:44 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     l4stpr0gr4m@...il.com, trivial@...nel.org
Cc:     michal.simek@...inx.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] docs/devicetree: mailbox: fix trivial typo

On 10. 05. 20 21:38, l4stpr0gr4m@...il.com wrote:
> From: Kangmin Park <l4stpr0gr4m@...il.com>
> 
> Fix node id typo in example

I think it is more than typo. It is incorrect unit-address which doesn't
match the first address specified in the reg property of the node.

Here is line from dt binding spec.
"The unit-address must match the first address specified in the
reg property of the node."



> 
> Signed-off-by: Kangmin Park <l4stpr0gr4m@...il.com>

IIRC subject should start with dt-bindings:


> ---
>  Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> index 4438432..ad76edc 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> @@ -87,7 +87,7 @@ Example:
>  		ranges;
>  
>  		/* APU<->RPU0 IPI mailbox controller */
> -		ipi_mailbox_rpu0: mailbox@...0400 {
> +		ipi_mailbox_rpu0: mailbox@...90400 {
>  			reg = <0xff990400 0x20>,
>  			      <0xff990420 0x20>,
>  			      <0xff990080 0x20>,
> 

Change is correct.

With nits above applied please add my
Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal