linux-kernel - Re: [PATCH v6 5/9] w1_therm: adding resolution sysfs entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ad0616ecc6ec6ecf4622eca878ba7e7c52c475e.camel@gmail.com>
Date:   Mon, 11 May 2020 09:13:38 +0200
From:   Akira shimahara <akira215corp@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, greg@...ah.com
Cc:     zbr@...emap.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/9] w1_therm: adding resolution sysfs entry

Hi,

Le dimanche 10 mai 2020 à 20:25 -0700, Randy Dunlap a écrit :
> Hi,
> 
> 
> 
> The kernel-doc comment changes look good.  Thanks for doing that.
> 
> 
> 
> 
> 
> On 5/10/20 7:17 AM, Akira Shimahara wrote:
> 
> 
> 
> > diff --git a/drivers/w1/slaves/w1_therm.c
> > b/drivers/w1/slaves/w1_therm.c
> > index 08579dc..b1734ae 100644
> > --- a/drivers/w1/slaves/w1_therm.c
> > +++ b/drivers/w1/slaves/w1_therm.c
> > @@ -50,12 +50,24 @@ module_param_named(strong_pullup,
> > w1_strong_pullup, int, 0);
> >   
> >   /* Helpers Macros */
> >   
> > +/* return a pointer on the slave w1_therm_family_converter struct:
> > + * always test family data existence before
> > + */
> 
> 
> /*
> 
>  * Kernel multi-line comment coding style (except for networking
> source code)
> 
>  * is like this.
> 
>  */
> 
> 
> 
> (in multiple places)
> 
> 
> 
> > +/**
> > + * write_scratchpad() - write nb_bytes in the device RAM
> > + * @sl: pointer to the slave to write in
> > + * @data: pointer to an array of 3 bytes, as 3 bytes MUST be
> > written
> > + * @nb_bytes: Nb bytes to be written (2 for DS18S20, 3 for other
> > devices)
> 
> 
> If Nb means Number, please spell it out.
> 
> 
> 
> > + *
> > + * Return: 0 if success, -kernel error code otherwise
> > + */
> > +static int write_scratchpad(struct w1_slave *sl, const u8 *data,
> > u8 nb_bytes);
> > +
> >   /**
> >    * read_powermode() - Query the power mode of the slave
> >    * @sl: slave to retrieve the power mode
> 
> 
> 
> 
> thanks.
> 
> --
> 
> ~Randy

Thanks for your comments and your time,
well noted, I will do
accordingly.

Akira Shimahara