lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: 11 May 2020 10:30:15 +0900 From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com> To: Yongbo Zhang <giraffesnn123@...il.com> Cc: broonie@...nel.org, lgirdwood@...il.com, alsa-devel@...a-project.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, Chen Li <licheng0822@...ndersoft.com> Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer Hi Yongbo Thank you for the patch > SSI BUSIF buffer is possible to overflow or underflow, especially in a > hypervisor environment. If there is no interrupt support, it will eventually > lead to errors in pcm data. > This patch adds overflow and underflow interrupt support for SSI BUSIF buffer. > > Cc: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com> > Reported-by: Chen Li <licheng0822@...ndersoft.com> > Signed-off-by: Yongbo Zhang <giraffesnn123@...il.com> > Tested-by: Chen Li <licheng0822@...ndersoft.com> > --- (snip) > @@ -635,6 +713,19 @@ static int rsnd_ssi_irq(struct rsnd_mod *mod, > if (enable) > val = rsnd_ssi_is_dma_mode(mod) ? 0x0e000000 : 0x0f000000; > > + if (is_tdm || is_tdm_split) { > + switch (id) { > + case 0: > + case 1: > + case 2: > + case 3: > + case 4: > + case 9: > + val |= 0xff00; > + break; > + } > + } This is small things, but we like to have - val |= 0xff00; + val |= 0x0000ff00; Except above Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com> Thank you for your help !! Best regards --- Kuninori Morimoto
Powered by blists - more mailing lists