linux-kernel - Re: [patch V4 part 5 13/31] x86/irq: Convey vector as argument and not in ptregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 23:11:43 +0800
From:   Lai Jiangshan <jiangshanlai+lkml@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Brian Gerst <brgerst@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [patch V4 part 5 13/31] x86/irq: Convey vector as argument and
 not in ptregs

Hello

On Mon, May 11, 2020 at 10:35 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> Lai,
>
> Lai Jiangshan <jiangshanlai+lkml@...il.com> writes:
> > On Tue, May 5, 2020 at 10:23 PM Thomas Gleixner <tglx@...utronix.de> wrote:
> >> +SYM_CODE_START(irq_entries_start)
> >> +    vector=FIRST_EXTERNAL_VECTOR
> >> +    .rept (FIRST_SYSTEM_VECTOR - FIRST_EXTERNAL_VECTOR)
> >> +       UNWIND_HINT_IRET_REGS
> >> +       .byte   0x6a, vector
> >> +       jmp     common_interrupt
> >> +       .align  8
> >> +    vector=vector+1
> >> +    .endr
> >> +SYM_CODE_END(irq_entries_start)
> >
> > Using ".byte   0x6a, vector" is somewhat ugly.
> >
> > I hope it should be " pushq $(s8_to_s64(vector))", which can also
> > help to reduce bunches of comments about ".byte   0x6a, vector".
> >
> > However, I don't know how to implement s8_to_s64() here.
>
> Neither do I.
>
> > But at least the following code works (generates the same two-byte
> > machine code as ".byte 0x6a, vector" does):
> >
> >         .if vector < 128
> >         pushq $(vector)
> >         .else
> >         pushq $(0xffffffffffffff00+vector)
> >         .endif
>
> Only slightly less ugly and needs as much commentry as the above.

Agree.

Just FYI, I tried this later, it can work.

#define S8_TO_S64(vector) ((vector>>7)*0xffffffffffffff00+vector)

Thanks
Lai