lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 May 2020 16:33:06 +0000 From: Derek Chickles <dchickles@...vell.com> To: Luis Chamberlain <mcgrof@...nel.org>, "jeyu@...nel.org" <jeyu@...nel.org> CC: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "arnd@...db.de" <arnd@...db.de>, "rostedt@...dmis.org" <rostedt@...dmis.org>, "mingo@...hat.com" <mingo@...hat.com>, "aquini@...hat.com" <aquini@...hat.com>, "cai@....pw" <cai@....pw>, "dyoung@...hat.com" <dyoung@...hat.com>, "bhe@...hat.com" <bhe@...hat.com>, "peterz@...radead.org" <peterz@...radead.org>, "tglx@...utronix.de" <tglx@...utronix.de>, "gpiccoli@...onical.com" <gpiccoli@...onical.com>, "pmladek@...e.com" <pmladek@...e.com>, "tiwai@...e.de" <tiwai@...e.de>, "schlad@...e.de" <schlad@...e.de>, "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>, "keescook@...omium.org" <keescook@...omium.org>, "daniel.vetter@...ll.ch" <daniel.vetter@...ll.ch>, "will@...nel.org" <will@...nel.org>, "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>, "kvalo@...eaurora.org" <kvalo@...eaurora.org>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Satananda Burla <sburla@...vell.com>, "Felix Manlunas" <fmanlunas@...vell.com> Subject: RE: [PATCH 06/15] liquidio: use new module_firmware_crashed() > From: Luis Chamberlain <mcgrof@...nel.org> > Sent: Friday, May 8, 2020 9:36 PM > To: jeyu@...nel.org > Cc: akpm@...ux-foundation.org; arnd@...db.de; rostedt@...dmis.org; > mingo@...hat.com; aquini@...hat.com; cai@....pw; dyoung@...hat.com; > bhe@...hat.com; peterz@...radead.org; tglx@...utronix.de; > gpiccoli@...onical.com; pmladek@...e.com; tiwai@...e.de; > schlad@...e.de; andriy.shevchenko@...ux.intel.com; > keescook@...omium.org; daniel.vetter@...ll.ch; will@...nel.org; > mchehab+samsung@...nel.org; kvalo@...eaurora.org; > davem@...emloft.net; netdev@...r.kernel.org; linux- > kernel@...r.kernel.org; Luis Chamberlain <mcgrof@...nel.org>; Derek > Chickles <dchickles@...vell.com>; Satananda Burla <sburla@...vell.com>; > Felix Manlunas <fmanlunas@...vell.com> > Subject: [PATCH 06/15] liquidio: use new module_firmware_crashed() > > ---------------------------------------------------------------------- > This makes use of the new module_firmware_crashed() to help annotate > when firmware for device drivers crash. When firmware crashes devices can > sometimes become unresponsive, and recovery sometimes requires a driver > unload / reload and in the worst cases a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Derek Chickles <dchickles@...vell.com> > Cc: Satanand Burla <sburla@...vell.com> > Cc: Felix Manlunas <fmanlunas@...vell.com> > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> > --- > drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c > b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 66d31c018c7e..f18085262982 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param) > continue; > > WRITE_ONCE(oct->cores_crashed, true); > + module_firmware_crashed(); > other_oct = get_other_octeon_device(oct); > if (other_oct) > WRITE_ONCE(other_oct->cores_crashed, true); > -- > 2.25.1 Thanks! Reviewed-by: Derek Chickles <dchickles@...vell.com>
Powered by blists - more mailing lists