lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 May 2020 10:07:47 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Joe Perches <joe@...ches.com> Cc: davem@...emloft.net, Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org, andrew@...n.ch, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v2] checkpatch: warn about uses of ENOTSUPP On Mon, 11 May 2020 10:03:31 -0700 Joe Perches wrote: > On Mon, 2020-05-11 at 09:53 -0700, Jakub Kicinski wrote: > > ENOTSUPP often feels like the right error code to use, but it's > > in fact not a standard Unix error. E.g.: > [] > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -4199,6 +4199,17 @@ sub process { > > "ENOSYS means 'invalid syscall nr' and nothing else\n" . $herecurr); > > } > > > > +# ENOTSUPP is not a standard error code and should be avoided in new patches. > > +# Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP. > > +# Similarly to ENOSYS warning a small number of false positives is expected. > > + if (~$file && $line =~ /\bENOTSUPP\b/) { > > It's probably my typo or my brain thinking "not" and hitting > the tilde and not the bang, but this should be > > if (!$file & ...) Ahh! :) > Otherwise: > > Acked-by: Joe Perches <joe@...ches.com> Thanks!
Powered by blists - more mailing lists