linux-kernel - Re: [PATCH v2 5/5] mfd: lochnagar: Move binding over to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 May 2020 08:49:49 -0500
From:   Rob Herring <robh@...nel.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     lee.jones@...aro.org, broonie@...nel.org, mturquette@...libre.com,
        sboyd@...nel.org, jdelvare@...e.com, linux@...ck-us.net,
        linus.walleij@...aro.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH v2 5/5] mfd: lochnagar: Move binding over to dtschema

On Mon, May 04, 2020 at 04:47:57PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> ---
> 
> Changes since v1:
>  - Removed contains on the compatible
>  - Moved all sub-nodes into here directly only using $ref for properties
>  - As the regulator binding only contained subnodes that file is now deleted
>  - Removed some pointless descriptions
> 
> A little nervous about the amount of clock and regulator stuff this
> pulls into the MFD file, any comments on that welcome? Would it be worth
> looking into something along the lines of the definitions stuff to keep
> some of that out in the clock and regulator bindings?

It's fine like this. Other than my comments on patch 3, looks fine. 
Respin and I'll apply.

> 
> Thanks,
> Charles
> 
>  .../devicetree/bindings/mfd/cirrus,lochnagar.txt   |  85 -----
>  .../devicetree/bindings/mfd/cirrus,lochnagar.yaml  | 352 +++++++++++++++++++++
>  .../bindings/regulator/cirrus,lochnagar.txt        |  82 -----
>  MAINTAINERS                                        |  11 +-
>  4 files changed, 357 insertions(+), 173 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mfd/cirrus,lochnagar.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
>  delete mode 100644 Documentation/devicetree/bindings/regulator/cirrus,lochnagar.txt