lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2020 13:18:38 -0700 From: Brendan Higgins <brendanhiggins@...gle.com> To: Heikki Krogerus <heikki.krogerus@...ux.intel.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Naresh Kamboju <naresh.kamboju@...aro.org>, kernel test robot <rong.a.chen@...el.com>, Randy Dunlap <rdunlap@...radead.org>, "Rafael J. Wysocki" <rafael@...nel.org> Subject: Re: [PATCH] kobject: Make sure the parent does not get released before its children On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus <heikki.krogerus@...ux.intel.com> wrote: > > In the function kobject_cleanup(), kobject_del(kobj) is > called before the kobj->release(). That makes it possible to > release the parent of the kobject before the kobject itself. > > To fix that, adding function __kboject_del() that does > everything that kobject_del() does except release the parent > reference. kobject_cleanup() then calls __kobject_del() > instead of kobject_del(), and separately decrements the > reference count of the parent kobject after kobj->release() > has been called. I was starting to wonder if anything else needed to happen with this. :-) Thanks for taking care of this! > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org> > Reported-by: kernel test robot <rong.a.chen@...el.com> > Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"") > Cc: Brendan Higgins <brendanhiggins@...gle.com> > Cc: Randy Dunlap <rdunlap@...radead.org> > Suggested-by: "Rafael J. Wysocki" <rafael@...nel.org> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> Didn't I and someone else test this? Either way, I will test this out in a little bit. Thanks!
Powered by blists - more mailing lists