linux-kernel - Re: [PATCH] kobject: Make sure the parent does not get released before its children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca1db965-e3aa-7c86-27b2-92fb4707ddb5@infradead.org>
Date:   Wed, 13 May 2020 13:54:15 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Brendan Higgins <brendanhiggins@...gle.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        kernel test robot <rong.a.chen@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] kobject: Make sure the parent does not get released
 before its children

On 5/13/20 1:18 PM, Brendan Higgins wrote:
> On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
>>
>> In the function kobject_cleanup(), kobject_del(kobj) is
>> called before the kobj->release(). That makes it possible to
>> release the parent of the kobject before the kobject itself.
>>
>> To fix that, adding function __kboject_del() that does
>> everything that kobject_del() does except release the parent
>> reference. kobject_cleanup() then calls __kobject_del()
>> instead of kobject_del(), and separately decrements the
>> reference count of the parent kobject after kobj->release()
>> has been called.
> 
> I was starting to wonder if anything else needed to happen with this. :-)
> 
> Thanks for taking care of this!
> 
>> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>> Reported-by: kernel test robot <rong.a.chen@...el.com>
>> Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"")
>> Cc: Brendan Higgins <brendanhiggins@...gle.com>
>> Cc: Randy Dunlap <rdunlap@...radead.org>
>> Suggested-by: "Rafael J. Wysocki" <rafael@...nel.org>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 
> Didn't I and someone else test this?
> 
> Either way, I will test this out in a little bit.
> 
> Thanks!
> 

Yes, I tested the earlier patch and acked it.
(using lib/test_printf.ko)

-- 
~Randy