linux-kernel - Re: [PATCH] perf tools: Replace zero-length array with flexible-array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWOhnKe1-c39Pg9M14Yet7U1jRvPpKxa7N2A6JSXLRe=Q@mail.gmail.com>
Date:   Wed, 13 May 2020 14:03:56 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Arnaldo Melo <arnaldo.melo@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH] perf tools: Replace zero-length array with flexible-array

On Tue, May 12, 2020 at 10:59 AM Gustavo A. R. Silva
<gustavoars@...nel.org> wrote:
>
> On Tue, May 12, 2020 at 10:06:07AM +0200, Peter Zijlstra wrote:
> > On Mon, May 11, 2020 at 07:04:04PM -0500, Gustavo A. R. Silva wrote:
> > > On Mon, May 11, 2020 at 05:20:08PM -0300, Arnaldo Melo wrote:
> > > >
> > > > Thanks, applied
> > > >
> > >
> > > Thanks, Arnaldo.
> > >
> > > I wonder if could also take the other two:
> > >
> > > https://lore.kernel.org/lkml/20200511200911.GA13149@embeddedor/
> > > https://lore.kernel.org/lkml/20200511201227.GA14041@embeddedor/
> >
> > I think I have those, but let me make sure.
>
> Great. :)


Thanks for the cleanup! It has yielded a clang compiler warning/error
for me in kernel/git/acme/linux.git branch perf/core:

util/intel-pt.c:1802:24: error: field 'br_stack' with variable sized
type 'struct branch_stack' not
at the end of a struct or class is a GNU extension
[-Werror,-Wgnu-variable-sized-type-not-at-end]
                       struct branch_stack br_stack;

I think this can be resolved by reordering the members of the struct,
and may have been a latent bug exposed by this change. It's
unfortunate it has broken this build.

Thanks,
Ian

> Thanks
> --
> Gustavo
>