linux-kernel - Re: [PATCH][next] net: dsa: felix: fix incorrect clamp calculation for burst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpdw5aXLnS0VRnf1XWkseKY83pAoqvUuM09xAFLHyrqWw@mail.gmail.com>
Date:   Thu, 14 May 2020 23:59:50 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] net: dsa: felix: fix incorrect clamp calculation
 for burst

Hi Colin,

On Thu, 14 May 2020 at 21:34, Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently burst is clamping on rate and not burst, the assignment
> of burst from the clamping discards the previous assignment of burst.
> This looks like a cut-n-paste error from the previous clamping
> calculation on ramp.  Fix this by replacing ramp with burst.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 0fbabf875d18 ("net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Acked-by: Vladimir Oltean <vladimir.oltean@....com>

>  drivers/net/dsa/ocelot/felix_vsc9959.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
> index df4498c0e864..85e34d85cc51 100644
> --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
> +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
> @@ -1360,7 +1360,7 @@ static int vsc9959_qos_port_cbs_set(struct dsa_switch *ds, int port,
>         /* Burst unit is 4kB */
>         burst = DIV_ROUND_UP(cbs_qopt->hicredit, 4096);
>         /* Avoid using zero burst size */
> -       burst = clamp_t(u32, rate, 1, GENMASK(5, 0));
> +       burst = clamp_t(u32, burst, 1, GENMASK(5, 0));
>         ocelot_write_gix(ocelot,
>                          QSYS_CIR_CFG_CIR_RATE(rate) |
>                          QSYS_CIR_CFG_CIR_BURST(burst),
> --
> 2.25.1
>

Thanks!
-Vladimir