linux-kernel - Re: [PATCH][next] net: dsa: felix: fix incorrect clamp calculation for burst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200514.180322.2120900678402639632.davem@davemloft.net>
Date:   Thu, 14 May 2020 18:03:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     vladimir.oltean@....com, claudiu.manoil@....com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        xiaoliang.yang_1@....com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: dsa: felix: fix incorrect clamp calculation
 for burst

From: Colin King <colin.king@...onical.com>
Date: Thu, 14 May 2020 19:33:02 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently burst is clamping on rate and not burst, the assignment
> of burst from the clamping discards the previous assignment of burst.
> This looks like a cut-n-paste error from the previous clamping
> calculation on ramp.  Fix this by replacing ramp with burst.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: 0fbabf875d18 ("net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.