lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 May 2020 16:02:49 -0700
From:   Ian Rogers <>
To:     John Garry <>
Cc:     Peter Zijlstra <>,
        Ingo Molnar <>,
        Arnaldo Carvalho de Melo <>,
        Mark Rutland <>,
        Alexander Shishkin <>,
        Jiri Olsa <>,
        Namhyung Kim <>,
        Andi Kleen <>,
        Jin Yao <>,
        Leo Yan <>,
        Kan Liang <>,
        Kajol Jain <>,
        Adrian Hunter <>,
        Paul Clarke <>,
        "" <>,
        Stephane Eranian <>
Subject: Re: [PATCH 2/2] perf test: Improve pmu event metric testing

On Thu, May 14, 2020 at 2:00 AM John Garry <> wrote:
> On 13/05/2020 17:10, Ian Rogers wrote:
> >> Out of interest, if we could move the validation of metrics to jevents,
> >> how much functionality would we still have here?
> > If we add checking to jevents then the MetricExpr would be known to be
> > valid, however, the events (aka ids) within the expression could be
> > invalid.
> So I think that has some value. I mean, just to detect syntax errors,
> like those remedied in "perf metrics: fix parse errors in power8 metrics".
> > I'm not sure we could realistically check the events at
> > jevents (build) time as there is no guarantee that the machine we run
> > on is the same as the one we compile on.
> But we could at least check that there are event aliases for that CPU,
> right? (by examining the JSONs for that cpu). If the event alias does
> not actually match on the target CPU, then that can't be helped.

Agreed, I think there will be some cases where something more can be
done. Jiri has proposed fake pmus as well:
I don't know how much sense it makes trying to get this in jevents, as
long as 'perf test' is run.


> Cheers,
> John

Powered by blists - more mailing lists