linux-kernel - Re: [PATCH 2/2] perf test: Improve pmu event metric testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5264e16c-fb1a-4bbc-96b5-1d867e38902e@huawei.com>
Date:   Thu, 14 May 2020 09:59:07 +0100
From:   John Garry <john.garry@...wei.com>
To:     Ian Rogers <irogers@...gle.com>
CC:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Leo Yan <leo.yan@...aro.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Paul Clarke <pc@...ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/2] perf test: Improve pmu event metric testing

On 13/05/2020 17:10, Ian Rogers wrote:
>> Out of interest, if we could move the validation of metrics to jevents,
>> how much functionality would we still have here?
> If we add checking to jevents then the MetricExpr would be known to be
> valid, however, the events (aka ids) within the expression could be
> invalid.

So I think that has some value. I mean, just to detect syntax errors, 
like those remedied in "perf metrics: fix parse errors in power8 metrics".

> I'm not sure we could realistically check the events at
> jevents (build) time as there is no guarantee that the machine we run
> on is the same as the one we compile on.

But we could at least check that there are event aliases for that CPU, 
right? (by examining the JSONs for that cpu). If the event alias does 
not actually match on the target CPU, then that can't be helped.

Cheers,
John