linux-kernel - Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Px+wV7o1P41ZdidpwNFtwWL1-RYcwV3dU9R7PG+66k1L_p_A@mail.gmail.com>
Date:   Thu, 14 May 2020 15:31:52 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Steve Lee <steves.lee.maxim@...il.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, ckeepax@...nsource.cirrus.com,
        geert@...ux-m68k.org, rf@...nsource.wolfsonmicro.com,
        Shuming [范書銘] <shumingf@...ltek.com>,
        Srini Kandagatla <srinivas.kandagatla@...aro.org>,
        Krzysztof Kozlowski <krzk@...nel.org>, dmurphy@...com,
        jack.yu@...ltek.com, nuno.sa@...log.com,
        steves.lee@...imintegrated.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ALSA development <alsa-devel@...a-project.org>,
        ryan.lee.maxim@...il.com, ryans.lee@...imintegrated.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

On Wed, May 13, 2020 at 3:47 PM Steve Lee <steves.lee.maxim@...il.com> wrote:
> +++ b/sound/soc/codecs/max98390.c
> @@ -0,0 +1,1030 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * max98390.c  --  MAX98390 ALSA Soc Audio driver
> + *
> + * Copyright (C) 2020 Maxim Integrated Products
> + *
> + */

My previous comments on Gerrit may confuse you.  Please use C++ style
comments (i.e. // for all lines) here as the maintainer asked.

Mark, may I ask why we need to do so?  Is it also applicable to header files?

> +static int max98390_dsm_calib_get(struct snd_kcontrol *kcontrol,
> +               struct snd_ctl_elem_value *ucontrol)
> +{
> +       /* Do nothing. */
> +
> +       return 0;
> +}

This is an intentional NOP.

> +static int max98390_dsm_calib_put(struct snd_kcontrol *kcontrol,
> +               struct snd_ctl_elem_value *ucontrol)
> +{
> +       struct snd_soc_component *component =
> +               snd_soc_kcontrol_component(kcontrol);
> +
> +       max98390_dsm_calibrate(component);
> +
> +       return 0;
> +}

Entry point from userspace to start to calibrate.

> +++ b/sound/soc/codecs/max98390.h
> @@ -0,0 +1,663 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2020, Maxim Integrated.
> + */

I guess these block would also need to use C++ style comment.