linux-kernel - Re: [PATCH] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aad9ad5-b0e9-12b0-0ad2-ac23fceae87b@physik.fu-berlin.de>
Date:   Thu, 14 May 2020 12:21:13 +0200
From:   John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     "Luck, Tony" <tony.luck@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Qais Yousef <qais.yousef@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ia64: enable HAVE_COPY_THREAD_TLS, switch to
 kernel_clone_args

On 5/14/20 12:19 PM, Christian Brauner wrote:
> Scratch that. It's even worse. On ia64 it is _invalid_ to pass a NULL
> stack. That's at least what the glibc assembly assumes:
> 
> 	cmp.eq p6,p0=0,in0
> 	cmp.eq p7,p0=0,in1
> 	mov r8=EINVAL
> 	mov out0=in3		/* Flags are first syscall argument.	*/
> 	mov out1=in1		/* Stack address.			*/
> (p6)	br.cond.spnt.many __syscall_error	/* no NULL function pointers */
> (p7)	br.cond.spnt.many __syscall_error	/* no NULL stack pointers */
> 	;;
> 	mov out2=in2		/* Stack size.				*/
> 
> so newer systemd just works by accident on ia64 if at all correctly
> afaict.

Hmm, interesting. I really wasn't aware of that. Thanks for the heads-up.

I'll ask Michael whether he can come up for a solution for that problem.

Maybe that's also why systemd crashes.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@...ian.org
`. `'   Freie Universitaet Berlin - glaubitz@...sik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913