[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200514103042.GA185537@smile.fi.intel.com>
Date: Thu, 14 May 2020 13:30:42 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Fengping Yu <fengping.yu@...iatek.com>
Cc: Yingjoe Chen <yingjoe.chen@...iatek.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Marco Felsch <m.felsch@...gutronix.de>,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver
On Thu, May 14, 2020 at 01:27:01PM +0300, Andy Shevchenko wrote:
> On Thu, May 14, 2020 at 02:17:48PM +0800, Fengping Yu wrote:
> > From: "fengping.yu" <fengping.yu@...iatek.com>
> >
> > This adds matrix keypad support for Mediatek SoCs.
>
> ...
>
> > +config KEYBOARD_MTK_KPD
> > + tristate "MediaTek Keypad Support"
>
> > + depends on OF && HAVE_CLK
>
> What makes it OF dependent?
Actually you missed regmap dependencies or selection. I dunno which one should
be used (IIRC selection).
> > + help
> > + Say Y here if you want to use the keypad on MediaTek SoCs.
> > + If unsure, say N.
> > + To compile this driver as a module, choose M here: the
> > + module will be called mtk-kpd.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists