linux-kernel - Re: [PATCH 08/11] drm: constify sysrq_key_op

Open Source and information security mailing list archives

Message-ID: <20200514123654.GT206103@phenom.ffwll.local>
Date:   Thu, 14 May 2020 14:36:54 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Emil Velikov <emil.l.velikov@...il.com>
Cc:     dri-devel@...ts.freedesktop.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH 08/11] drm: constify sysrq_key_op

On Wed, May 13, 2020 at 10:43:48PM +0100, Emil Velikov wrote:
> With earlier commits, the API no longer discards the const-ness of the
> sysrq_key_op. As such we can add the notation.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Emil Velikov <emil.l.velikov@...il.com>
> ---
> Please keep me in the CC list, as I'm not subscribed to the list.
> 
> IMHO it would be better if this gets merged this via the tty tree.

Shouldn't conflict, looks all reasonable for merging through tty as one
series.

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
Acked-by: Daniel Vetter <daniel.vetter@...ll.ch>

> ---
>  drivers/gpu/drm/drm_fb_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index a9771de4d17e..533767100efe 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -307,13 +307,13 @@ static void drm_fb_helper_sysrq(int dummy1)
>  	schedule_work(&drm_fb_helper_restore_work);
>  }
>  
> -static struct sysrq_key_op sysrq_drm_fb_helper_restore_op = {
> +static const struct sysrq_key_op sysrq_drm_fb_helper_restore_op = {
>  	.handler = drm_fb_helper_sysrq,
>  	.help_msg = "force-fb(V)",
>  	.action_msg = "Restore framebuffer console",
>  };
>  #else
> -static struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { };
> +static const struct sysrq_key_op sysrq_drm_fb_helper_restore_op = { };
>  #endif
>  
>  static void drm_fb_helper_dpms(struct fb_info *info, int dpms_mode)
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives