linux-kernel - Re: [PATCH 09/11] kdb: constify sysrq_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200514164629.6jxixnmi3tal5yfx@holly.lan>
Date:   Thu, 14 May 2020 17:46:29 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Emil Velikov <emil.l.velikov@...il.com>
Cc:     dri-devel@...ts.freedesktop.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        Jason Wessel <jason.wessel@...driver.com>,
        kgdb-bugreport@...ts.sourceforge.net
Subject: Re: [PATCH 09/11] kdb: constify sysrq_key_op

On Wed, May 13, 2020 at 10:43:49PM +0100, Emil Velikov wrote:
> With earlier commits, the API no longer discards the const-ness of the
> sysrq_key_op. As such we can add the notation.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: Jason Wessel <jason.wessel@...driver.com>
> Cc: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: kgdb-bugreport@...ts.sourceforge.net
> Signed-off-by: Emil Velikov <emil.l.velikov@...il.com>

Acked-by: Daniel Thompson <daniel.thompson@...aro.org>


> ---
> Please keep me in the CC list, as I'm not subscribed to the list.
> 
> IMHO it would be better if this gets merged this via the tty tree.
> ---
>  kernel/debug/debug_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index 2b7c9b67931d..355bea54ca0e 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -920,7 +920,7 @@ static void sysrq_handle_dbg(int key)
>  	kgdb_breakpoint();
>  }
>  
> -static struct sysrq_key_op sysrq_dbg_op = {
> +static const struct sysrq_key_op sysrq_dbg_op = {
>  	.handler	= sysrq_handle_dbg,
>  	.help_msg	= "debug(g)",
>  	.action_msg	= "DEBUG",
> -- 
> 2.25.1
>