linux-kernel - Re: [PATCH 1/4] hung_task: Move hung_task sysctl interface to hung_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202005150103.6DD6F07@keescook>
Date:   Fri, 15 May 2020 01:04:21 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     mcgrof@...nel.org, yzaikin@...gle.com, adobriyan@...il.com,
        mingo@...nel.org, peterz@...radead.org, akpm@...ux-foundation.org,
        yamada.masahiro@...ionext.com, bauerman@...ux.ibm.com,
        gregkh@...uxfoundation.org, skhan@...uxfoundation.org,
        dvyukov@...gle.com, svens@...ckframe.org, joel@...lfernandes.org,
        tglx@...utronix.de, Jisheng.Zhang@...aptics.com, pmladek@...e.com,
        bigeasy@...utronix.de, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, wangle6@...wei.com
Subject: Re: [PATCH 1/4] hung_task: Move hung_task sysctl interface to
 hung_task_sysctl.c

On Fri, May 15, 2020 at 12:33:41PM +0800, Xiaoming Ni wrote:
> Move hung_task sysctl interface to hung_task_sysctl.c.
> Use register_sysctl() to register the sysctl interface to avoid
> merge conflicts when different features modify sysctl.c at the same time.
> 
> Signed-off-by: Xiaoming Ni <nixiaoming@...wei.com>
> ---
>  include/linux/sched/sysctl.h |  8 +----
>  kernel/Makefile              |  4 ++-
>  kernel/hung_task.c           |  6 ++--
>  kernel/hung_task.h           | 21 ++++++++++++
>  kernel/hung_task_sysctl.c    | 80 ++++++++++++++++++++++++++++++++++++++++++++

Why a separate file? That ends up needing changes to Makefile, the
creation of a new header file, etc. Why not just put it all into
hung_task.c directly?

-Kees

-- 
Kees Cook