linux-kernel - Re: [PATCH] staging: android: ashmem: Fixed a issue related to file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200515080446.GA1398375@kroah.com>
Date:   Fri, 15 May 2020 10:04:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Anmol karn <anmol.karan123@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: ashmem: Fixed a issue related to
 file_operations

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, May 15, 2020 at 01:16:12PM +0530, Anmol karn wrote:
> Hello sir,
> Thank you for your response,
> 
> Did you properly build this change?
> 
> 
> I have build the *linux_stable* according to the LFD103 course (By Linux
> Foundation) and the kernel they used in their tutorial was *5.2.21  *so, my
> question is can I use this kernel for the patch or do I need to switch to
> the recent mainline kernel release. Because in the recent patch I have used
> *5.2.21.*

Working on a 6 month old kernel is not going to help at all, you need to
work on the latest tree at the least.  linux-next is best.  Otherwise
you end up making changes that can not be applied, or have already been
done by others, which is just a waste of time.

But what I asked is if you actually test built the change you made.  As
the kbuild bot showed you, you obviously did not :(

Please always do that, you can not add new warnings to the kernel, nor
break the build with any change.

Also work on your knowledge of C before doing more kernel work, as the
change is not correct for the obvious reasons that it is not allowed by
the language.  checkpatch is just a perl script, sometimes it give
incorrect information, like this time.

> Also, always use your full name for kernel changes, as the Documentation
> > states to.
> 
> 
>  Sir, my legal full name is 'Anmol' only.

That does not match what your email "From:" says :)

greg k-h