linux-kernel - Re: [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200515134859.GA2112248@kroah.com>
Date:   Fri, 15 May 2020 15:48:59 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Matej Dujava <mdujava@...urkovo.cz>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile
 variable definitions

On Wed, May 13, 2020 at 09:15:51PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put
> obj-$(CONFIG_X) at the beginning of the file. This order of variables is
> used in other drives, so this will make vt665x Makefiles fit into the
> pattern.
> 
> Indentation is fixed in vt6655/Makefile.
> 
> Order of variable declaration is changed in vt6656/Makefile.
> 
> Signed-off-by: Matej Dujava <mdujava@...urkovo.cz>
> ---
> v1: Initial patch
> v2: This patch was split from original bigger patch
> v3: Added more info about what and why it's removed
> 
>  drivers/staging/vt6655/Makefile | 24 ++++++++++++------------
>  drivers/staging/vt6656/Makefile |  4 ++--
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
> index e70357ec0af8..eda08a1516ab 100644
> --- a/drivers/staging/vt6655/Makefile
> +++ b/drivers/staging/vt6655/Makefile
> @@ -1,15 +1,15 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
> -vt6655_stage-y +=	device_main.o \
> -	card.o \
> -	channel.o \
> -	mac.o \
> -	baseband.o \
> -	rxtx.o \
> -	dpc.o \
> -	power.o \
> -	srom.o \
> -	key.o \
> -	rf.o
> -
>  obj-$(CONFIG_VT6655) +=	vt6655_stage.o
> +
> +vt6655_stage-y +=	device_main.o \
> +			card.o \
> +			channel.o \
> +			mac.o \
> +			baseband.o \
> +			rxtx.o \
> +			dpc.o \
> +			power.o \
> +			srom.o \
> +			key.o \
> +			rf.o
> diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
> index f696a9d7a143..aac323d6a684 100644
> --- a/drivers/staging/vt6656/Makefile
> +++ b/drivers/staging/vt6656/Makefile
> @@ -1,5 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
> +obj-$(CONFIG_VT6656) +=	vt6656_stage.o
> +
>  vt6656_stage-y +=	main_usb.o \
>  			card.o  \
>  			mac.o   \
> @@ -11,5 +13,3 @@ vt6656_stage-y +=	main_usb.o \
>  			rf.o \
>  			usbpipe.o \
>  			channel.o
> -
> -obj-$(CONFIG_VT6656) +=	vt6656_stage.o

I still fail to understand the need for this patch at all.  It doesn't
clean anything up, nor change anything.  There is no rule that this has
to be in one order or the other, and in fact, I like the order that the
files currently have :)

thanks,

greg k-h