linux-kernel - Re: [PATCH v2 08/19] spi: dw: Discard dma_width member of the dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200515134956.GC1634618@smile.fi.intel.com>
Date:   Fri, 15 May 2020 16:49:56 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Georgy Vlasov <Georgy.Vlasov@...kalelectronics.ru>,
        Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Allison Randal <allison@...utok.net>,
        Gareth Williams <gareth.williams.jx@...esas.com>,
        Arnd Bergmann <arnd@...db.de>,
        Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
        devicetree@...r.kernel.org,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Clement Leger <cleger@...ray.eu>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        "wuxu.wu" <wuxu.wu@...wei.com>,
        Phil Edworthy <phil.edworthy@...esas.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/19] spi: dw: Discard dma_width member of the dw_spi
 structure

On Fri, May 15, 2020 at 04:05:59PM +0300, Serge Semin wrote:
> On Fri, May 15, 2020 at 04:03:05PM +0300, Andy Shevchenko wrote:
> > On Fri, May 15, 2020 at 01:47:47PM +0300, Serge Semin wrote:
> > > This member has exactly the same value as n_bytes of the DW SPI private
> > > data object, it's calculated at the same point of the transfer method,
> > > n_bytes isn't changed during the whole transfer, and they even serve for
> > > the same purpose - keep number of bytes per transfer word, though the
> > > dma_width is used only to calculate the DMA source/destination addresses
> > > width, which n_bytes could be also utilized for. Taking all of these
> > > into account let's replace the dma_width member usage with n_bytes one
> > > and remove the former.
> > 
> > I've no strong opinion about this.
> > So, after addressing one issue below,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

...

> > > -static enum dma_slave_buswidth convert_dma_width(u32 dma_width) {
> > > -	if (dma_width == 1)
> > 
> > > +static enum dma_slave_buswidth convert_dma_width(u8 n_bytes) {
> > 
> > It seems somebody (maybe even me) at some point messed up between enum
> > definition and function that returns an enum.
> > 
> > For what said, { should be on the separate line.
> 
> See the patch 16/19: "spi: dw: Cleanup generic DW DMA code namings"
> in this series.

Since you are touching that line here, it makes sense to do it here rather than
ping-pong to other patch in very same series.

-- 
With Best Regards,
Andy Shevchenko