linux-kernel - Re: [patch v2 1/2] ls1043ardb: add qe node to ls1043ardb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 17 May 2020 22:10:12 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Qiang Zhao <qiang.zhao@....com>
Cc:     leoyang.li@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [patch v2 1/2] ls1043ardb: add qe node to ls1043ardb

On Wed, Apr 29, 2020 at 04:20:51PM +0800, Qiang Zhao wrote:
> From: Zhao Qiang <qiang.zhao@....com>
> 
> Add qe node to fsl-ls1043a.dtsi and fsl-ls1043a-rdb.dts
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@....com>

Subject prefix should be like 'arm64: dts: ...'


> ---
> v2:
> - add commit msg and drop a new blank line
> 
>  arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 16 ++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi    | 65 +++++++++++++++++++++++
>  2 files changed, 81 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 4223a23..96e87ba 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -96,6 +96,22 @@
>  	};
>  };
>  
> +&uqe {

Keep labeling node sort alphabetically.

> +	ucc_hdlc: ucc@...0 {
> +		compatible = "fsl,ucc-hdlc";
> +		rx-clock-name = "clk8";
> +		tx-clock-name = "clk9";
> +		fsl,rx-sync-clock = "rsync_pin";
> +		fsl,tx-sync-clock = "tsync_pin";
> +		fsl,tx-timeslot-mask = <0xfffffffe>;
> +		fsl,rx-timeslot-mask = <0xfffffffe>;
> +		fsl,tdm-framer-type = "e1";
> +		fsl,tdm-id = <0>;
> +		fsl,siram-entry-id = <0>;
> +		fsl,tdm-interface;
> +	};
> +};
> +
>  &duart0 {
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index c084c7a4..674e671 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -525,6 +525,71 @@
>  			#interrupt-cells = <2>;
>  		};
>  
> +		uqe: uqe@...0000 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			device_type = "qe";

Is this really needed?  I can not find it in bindings doc qe.txt.

> +			compatible = "fsl,qe", "simple-bus";
> +			ranges = <0x0 0x0 0x2400000 0x40000>;
> +			reg = <0x0 0x2400000 0x0 0x480>;
> +			brg-frequency = <100000000>;
> +			bus-frequency = <200000000>;
> +			fsl,qe-num-riscs = <1>;
> +			fsl,qe-num-snums = <28>;
> +
> +			qeic: qeic@80 {
> +				compatible = "fsl,qe-ic";
> +				reg = <0x80 0x80>;
> +				#address-cells = <0>;
> +				interrupt-controller;
> +				#interrupt-cells = <1>;
> +				interrupts = <0 77 0x04 0 77 0x04>;

Two identical interrupts?  Also, please use GIC_SPI and
IRQ_TYPE_LEVEL_HIGH defines.

Shawn

> +			};
> +
> +			si1: si@700 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,ls1043-qe-si",
> +						"fsl,t1040-qe-si";
> +				reg = <0x700 0x80>;
> +			};
> +
> +			siram1: siram@...0 {
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				compatible = "fsl,ls1043-qe-siram",
> +						"fsl,t1040-qe-siram";
> +				reg = <0x1000 0x800>;
> +			};
> +
> +			ucc@...0 {
> +				cell-index = <1>;
> +				reg = <0x2000 0x200>;
> +				interrupts = <32>;
> +				interrupt-parent = <&qeic>;
> +			};
> +
> +			ucc@...0 {
> +				cell-index = <3>;
> +				reg = <0x2200 0x200>;
> +				interrupts = <34>;
> +				interrupt-parent = <&qeic>;
> +			};
> +
> +			muram@...00 {
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				compatible = "fsl,qe-muram", "fsl,cpm-muram";
> +				ranges = <0x0 0x10000 0x6000>;
> +
> +				data-only@0 {
> +					compatible = "fsl,qe-muram-data",
> +					"fsl,cpm-muram-data";
> +					reg = <0x0 0x6000>;
> +				};
> +			};
> +		};
> +
>  		lpuart0: serial@...0000 {
>  			compatible = "fsl,ls1021a-lpuart";
>  			reg = <0x0 0x2950000 0x0 0x1000>;
> -- 
> 2.9.5
>