linux-kernel - Re: [PATCH 1/3] perf/x86/rapl: move RAPL support to common x86 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 May 2020 11:08:14 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...e.hu, irogers@...gle.com,
        kim.phillips@....com, jolsa@...hat.com
Subject: Re: [PATCH 1/3] perf/x86/rapl: move RAPL support to common x86 code

On Fri, May 15, 2020 at 02:57:31PM -0700, Stephane Eranian wrote:
> To prepare for support of both Intel and AMD RAPL.
> Move rapl.c to arch/x86/events. Rename config option.
> Fixup header paths.
> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>
> ---
>  arch/x86/events/Kconfig            | 8 ++++----
>  arch/x86/events/Makefile           | 1 +
>  arch/x86/events/intel/Makefile     | 2 --
>  arch/x86/events/{intel => }/rapl.c | 9 ++++++---
>  4 files changed, 11 insertions(+), 9 deletions(-)
>  rename arch/x86/events/{intel => }/rapl.c (98%)
> 
> diff --git a/arch/x86/events/Kconfig b/arch/x86/events/Kconfig
> index 9a7a1446cb3a0..e542c32b0a55f 100644
> --- a/arch/x86/events/Kconfig
> +++ b/arch/x86/events/Kconfig
> @@ -9,12 +9,12 @@ config PERF_EVENTS_INTEL_UNCORE
>  	Include support for Intel uncore performance events. These are
>  	available on NehalemEX and more modern processors.
>  
> -config PERF_EVENTS_INTEL_RAPL
> -	tristate "Intel rapl performance events"
> -	depends on PERF_EVENTS && CPU_SUP_INTEL && PCI
> +config PERF_EVENTS_X86_RAPL

This is going to make everybody's kconfig prompt for this again. Best to
to a backwards compat thing or just leave it have Intel in the name.