linux-kernel - Re: [PATCH 3/3] perf/x86/rapl: add AMD Fam17h RAPL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200518093402.GB277222@hirez.programming.kicks-ass.net>
Date:   Mon, 18 May 2020 11:34:02 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...e.hu, irogers@...gle.com,
        kim.phillips@....com, jolsa@...hat.com
Subject: Re: [PATCH 3/3] perf/x86/rapl: add AMD Fam17h RAPL support

On Fri, May 15, 2020 at 02:57:33PM -0700, Stephane Eranian wrote:

> +static struct perf_msr amd_rapl_msrs[] = {
> +	[PERF_RAPL_PP0]  = { 0, &rapl_events_cores_group, NULL},
> +	[PERF_RAPL_PKG]  = { MSR_AMD_PKG_ENERGY_STATUS,  &rapl_events_pkg_group,   test_msr },
> +	[PERF_RAPL_RAM]  = { 0, &rapl_events_ram_group,   NULL},
> +	[PERF_RAPL_PP1]  = { 0, &rapl_events_gpu_group,   NULL},
> +	[PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group,  NULL},
> +};

Why have those !PKG things initialized? Wouldn't they default to 0
anyway? If not, surely { 0, } is sufficient.