linux-kernel - Re: [PATCH] scsi: Fix incorrect usage of shost_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95d13fe2-e267-a536-def4-083a20c016be@acm.org>
Date:   Mon, 18 May 2020 07:39:30 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Ye Bin <yebin10@...wei.com>, martin.petersen@...cle.com,
        jejb@...ux.ibm.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: Fix incorrect usage of shost_for_each_device

On 2020-05-18 00:44, Ye Bin wrote:
> shost_for_each_device(sdev, shost) \
> 	for ((sdev) = __scsi_iterate_devices((shost), NULL); \
> 	     (sdev); \
> 	     (sdev) = __scsi_iterate_devices((shost), (sdev)))
> 
> When terminating shost_for_each_device() iteration with break or return,
> scsi_device_put() should be used to prevent stale scsi device references from
> being left behind.

Reviewed-by: Bart Van Assche <bvanassche@....org>